Constrain aws sdk #212
Merged
Constrain aws sdk #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadia206
approved these changes
Feb 5, 2025
|
@IsaacWarren do we not need constraints on the Conda build? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included in this PR
With aws-sdk-cpp 1.11.486 they changed behavior for s3 validation aws/aws-sdk-cpp#3253. This breaks writing to s3 tables. Until we or arrow fix this we need to constrain the version
Testing strategy
S3 tables write unit tests. These weren't failing on CI because we hadn't rebuilt our Arrow Fork so linux-64 was still using the old aws-sdk-cpp which works.
User facing changes
S3 Tables write works.
Checklist
[run CI]in your commit message.